fix(mcp): fail fast when seerr.server is not configured#74
Merged
electather merged 1 commit intofix/normalize-server-urlfrom Mar 16, 2026
Merged
fix(mcp): fail fast when seerr.server is not configured#74electather merged 1 commit intofix/normalize-server-urlfrom
electather merged 1 commit intofix/normalize-server-urlfrom
Conversation
Validate seerr.server immediately after logger init in runServe so the process exits with a clear error before registering tools or binding a port. Uses NormalizeServerURL so trailing-slash-only values are also rejected. Adds ValidateServeConfig as an exported helper for unit tests. Closes #64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp servepreviously started the HTTP listener (or stdio transport) even whenseerr.serverwas not configured, causing confusing failures only when a tool was first called. This PR adds an explicit validation step that rejects the blank-or-slash-only case immediately after logger init, before any tool is registered or any port is bound.Depends on #72 (
NormalizeServerURL).Closes #64
Changes
ValidateServeConfig()early inrunServe, afterinitLoggerand before auth/transport validationValidateServeConfig() erroras an exported function so unit tests can exercise it without starting the serverseerr-cli/cmd/apiutilinserve.goto reuseNormalizeServerURLfor the empty-after-normalisation checkTest plan
go test -v ./...passesgo fmt ./...produces no diffgo buildsucceedsChecklist
--help, comments)